Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try all public key algorithms available for a specific key type in SSH_MSG_USERAUTH_REQUEST #763

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Try all public key algorithms available for a specific key type in SSH_MSG_USERAUTH_REQUEST #763

merged 1 commit into from
Feb 4, 2022

Conversation

ylangisc
Copy link
Contributor

@ylangisc ylangisc commented Jan 6, 2022

Fix #761.

@ylangisc ylangisc requested a review from hierynomus as a code owner January 6, 2022 10:44
@codecov-commenter
Copy link

Codecov Report

Merging #763 (f1928dd) into master (32329e5) will decrease coverage by 0.07%.
The diff coverage is 53.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #763      +/-   ##
============================================
- Coverage     63.95%   63.87%   -0.08%     
  Complexity     1454     1454              
============================================
  Files           212      212              
  Lines          8630     8640      +10     
  Branches        812      814       +2     
============================================
  Hits           5519     5519              
- Misses         2683     2694      +11     
+ Partials        428      427       -1
Impacted Files Coverage Δ
...java/net/schmizz/sshj/transport/TransportImpl.java 65.14% <50.00%> (-1.25%) ⬇️
.../schmizz/sshj/userauth/method/KeyedAuthMethod.java 62.50% <55.55%> (-4.17%) ⬇️
...t/schmizz/sshj/connection/ConnectionException.java 33.33% <0.00%> (-11.12%) ⬇️
...main/java/net/schmizz/sshj/xfer/scp/SCPEngine.java 73.01% <0.00%> (-3.18%) ⬇️
...zz/sshj/connection/channel/ChannelInputStream.java 75.38% <0.00%> (-3.08%) ⬇️
...ain/java/net/schmizz/sshj/common/SSHException.java 74.19% <0.00%> (+6.45%) ⬆️
...net/schmizz/sshj/transport/TransportException.java 55.55% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32329e5...f1928dd. Read the comment docs.

@dkocher
Copy link
Contributor

dkocher commented Feb 2, 2022

@hierynomus It would be great to have this reviewed.

@hierynomus hierynomus merged commit aabb1be into hierynomus:master Feb 4, 2022
vladimirlagunov pushed a commit to JetBrains/intellij-deps-sshj that referenced this pull request Mar 21, 2022
@ylangisc @vladimirlagunov
Try all public key algorithms available for a specific key type in SS…
afea9c9 
…H_MSG_USERAUTH_REQUEST. (hierynomus#763)

(cherry picked from commit aabb1be)
@ylangisc ylangisc mentioned this pull request Apr 21, 2022
Closed
ylangisc added a commit to iterate-ch/jsch-agent-proxy that referenced this pull request Apr 21, 2022
@ylangisc
For RSA keys all possible signature algorithms must be tried. Also re…
4b813b8 
…fer to hierynomus/sshj#763.
@ylangisc ylangisc mentioned this pull request Apr 21, 2022
Merged
@filip-lebiecki filip-lebiecki mentioned this pull request May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hierynomus hierynomus hierynomus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Without support for rsa-sha2-* a connection is not possible anymore
4 participants
@ylangisc @codecov-commenter @dkocher @hierynomus